advancedxy commented on PR #435: URL: https://github.com/apache/incubator-uniffle/pull/435#issuecomment-1369482858
> > > > In step 2 and 3, you may pass a ShuffleDataFileId/ ShuffleIndexId to indicate which shuffle file is fetched. It may be effectively the same as StorageId, but I believe it's more natural to use ShuffleDataFileId here. > > > > > > > > > `ShuffleDataFileId` is `ShuffleDataFileName` ? > > > > > > It could be, but mostly it would be the base path of shuffleDataFile.. As the `ShuffleDataFileName` could be generated by the rule. > > Concrete data file name is necessary which could not be generated by client, because there are multi files for one partition. I see, make sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
