zuston commented on code in PR #457:
URL: https://github.com/apache/incubator-uniffle/pull/457#discussion_r1063252003
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/reader/RssShuffleDataIterator.java:
##########
@@ -120,10 +115,20 @@ public boolean hasNext() {
shuffleReadMetrics.incRemoteBytesRead(compressedDataLength);
int uncompressedLen = compressedBlock.getUncompressLength();
- if (uncompressedData == null || uncompressedData.capacity() <
uncompressedLen) {
+ if (uncompressedData == null) {
+ // todo: support off-heap bytebuffer
+ uncompressedData = ByteBuffer.allocate(
+ (int) rssConf.getSizeAsBytes(
+ RssClientConfig.RSS_WRITER_BUFFER_SIZE,
Review Comment:
Yes. The initial `uncompressedData` size is hard to set. I prefer to remove
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
