advancedxy commented on PR #459: URL: https://github.com/apache/incubator-uniffle/pull/459#issuecomment-1375210800
The fix looks good to me. But could you elaborate a bit more in the pr description's `Why are the changes needed` section. If I understand the issue and this fix correctly, the reason why some appId is called multiple times is that: ``` When some appIds' removeResource took too much time, the `expiredAppCleanupExecutorService` in ShuffleTaskManager would check and detect the same appId is expired multiple times. Therefore the same appId might be added to `expiredAppIdQueue` multiple time. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
