advancedxy commented on code in PR #449: URL: https://github.com/apache/incubator-uniffle/pull/449#discussion_r1065311345
########## common/src/main/java/org/apache/uniffle/common/storage/StorageTypePOJO.java: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.uniffle.common.storage; + +import org.apache.uniffle.proto.RssProtos.StorageInfo; + +/** + * The POJO stands for plain old java object. The suffix exists to avoid conflict with another StorageType class. + */ +public enum StorageTypePOJO { Review Comment: > If they have diferent package names, there isn't conflict names. Unlike scala, java doesn't support class name renaming in the import path, and you cannot import the same class name in one file even if they are from different packages. It's extremely strange to use a fully qualified class name in java file and that always indicates some code smell. And FYI, I have renamed all the `StorageTypePOJO` to `StorageMedia` due to @zuston's suggestion, which I think it's a better name. P.S. you cannot do the following in one java file ``` import org.apache.uniffle.common.storage.StorageType import org.apache.uniffle.storage.util.StorageType ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
