advancedxy commented on PR #471: URL: https://github.com/apache/incubator-uniffle/pull/471#issuecomment-1380296359
> > I'm ok to add rss.server.huge-partition.size.threshold setting, which is used to add memory limit. I just think maybe we should reuse rss.server.single.buffer.flush.threshold instead of another rss.server.huge-partition.memory.limit.ratio settings? > > This suggestion has been accepted 😁 (Here: [#471 (comment)](https://github.com/apache/incubator-uniffle/pull/471#issuecomment-1379753276)). > > Please review the latest code. en. I will take a look in details by tomorrow. But on the surface, the `rss.server.huge-partition.memory.limit.ratio` setting still existed? <img width="944" alt="image" src="https://user-images.githubusercontent.com/807537/212071766-b4f6be0a-0106-4332-8f9e-680910815da2.png";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/807537/212071766-b4f6be0a-0106-4332-8f9e-680910815da2.png"](https://user-images.githubusercontent.com/807537/212071766-b4f6be0a-0106-4332-8f9e-680910815da2.png"){kind=link}