zuston commented on code in PR #485:
URL: https://github.com/apache/incubator-uniffle/pull/485#discussion_r1070863867


##########
server/src/main/java/org/apache/uniffle/server/storage/HdfsStorageManager.java:
##########
@@ -84,31 +84,32 @@ public Storage selectStorage(ShuffleDataReadEvent event) {
   @Override
   public void removeResources(PurgeEvent event) {
     String appId = event.getAppId();
-    String user = event.getUser();
     HdfsStorage storage = getStorageByAppId(appId);
-    if (storage != null) {
-      if (event instanceof AppPurgeEvent) {
-        storage.removeHandlers(appId);
-      }
+    if (storage == null) {

Review Comment:
   OK. Let me recover this part



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to