advancedxy commented on code in PR #470:
URL: https://github.com/apache/incubator-uniffle/pull/470#discussion_r1089915876
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java:
##########
@@ -216,6 +245,12 @@ private void genServerToBlocks(ShuffleBlockInfo sbi,
List<ShuffleServerInfo> ser
partitionToBlocks.put(partitionId, Lists.newArrayList());
}
partitionToBlocks.get(partitionId).add(sbi);
+ if (excludeServers != null) {
Review Comment:
>
https://github.com/apache/incubator-uniffle/blob/8847ece10a21800e5deb608441fcc6129a6b841d/coordinator/src/main/java/org/apache/uniffle/coordinator/strategy/partition/ContinuousSelectPartitionStrategy.java#L30-L52
See this impl and another strategy: `RoundSelectPartitionStrategy`, I think
these two impls might include duplicated nodes in the serverlist for some
cases, such as:
1. 3 replica with only 2 nodes?
2. or other corner cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
