advancedxy commented on code in PR #520:
URL: https://github.com/apache/incubator-uniffle/pull/520#discussion_r1090525332
##########
server/src/main/java/org/apache/uniffle/server/Checker.java:
##########
@@ -17,8 +17,11 @@
package org.apache.uniffle.server;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+
public abstract class Checker {
+ @SuppressFBWarnings("URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
protected ShuffleServerConf conf;
Review Comment:
An abstract class has an empty constructor is ok.
However it's also possible to provide checker as an interface, then a
`AbstractChecker` with the one parameter constructor.
something like
```
// Checker.java
public interface Checker {
boolean checkIsHealthy();
}
// AbstractChecker.java
public abstract class AbstractChecker implements Checker {
AbstractChecker(ShuffleServerConf conf) {}
}
```
All the subclass of checker should extends `AbstractChecker`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
