advancedxy commented on code in PR #521:
URL: https://github.com/apache/incubator-uniffle/pull/521#discussion_r1091527169


##########
deploy/kubernetes/operator/pkg/controller/util/util.go:
##########
@@ -175,6 +175,7 @@ func GenerateInitContainers(rssPodSpec 
*v1alpha1.RSSPodSpec) []corev1.Container
                                Privileged: pointer.Bool(true),
                        },
                        VolumeMounts: 
GenerateHostPathVolumeMounts(rssPodSpec.HostPathMounts),
+                       Resources:    rssPodSpec.Resources,

Review Comment:
   It doesn't matter. We can use a small one, such as "cpu: 200Mi, memory: 
200MB".
   But it's easy to just infer the request/limit from main container.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to