jerqi commented on code in PR #696:
URL: https://github.com/apache/incubator-uniffle/pull/696#discussion_r1129241756
##########
bin/start-shuffle-server.sh:
##########
@@ -67,7 +67,7 @@ JAVA_LIB_PATH="-Djava.library.path=$HADOOP_HOME/lib/native"
echo "class path is $CLASSPATH"
MAX_DIRECT_MEMORY_OPTS=""
-if [ -n "$MAX_DIRECT_MEMORY_SIZE" ]; then
+if [ -n "${MAX_DIRECT_MEMORY_SIZE:-}" ]; then
Review Comment:
Yes, I test it by hand. We should keep consistent style with other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
