advancedxy commented on code in PR #684:
URL: https://github.com/apache/incubator-uniffle/pull/684#discussion_r1129275026
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorServer.java:
##########
@@ -179,6 +183,19 @@ private void initialization() throws Exception {
server = coordinatorFactory.getServer();
}
+ private void registerRESTAPI() throws Exception {
+ LOG.info("Register REST API");
+ jettyServer.addServlet(
Review Comment:
> There will be more and more rest apis in the future. It is still
troublesome to add an api under the current framework. So I think we can
consider it later. How about introduce Jersey? @advancedxy @jerqi @zuston
@kaijchen
I'm ok with current status. Let's make the new REST server framework a
followup PR. Jersey itself seems a bit complex, but the path annotation
https://eclipse-ee4j.github.io/jersey.github.io/documentation/latest/user-guide.html#d0e2081
is quite elegant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
