jerqi commented on code in PR #742:
URL: https://github.com/apache/incubator-uniffle/pull/742#discussion_r1141406412
##########
common/src/main/java/org/apache/uniffle/common/ShuffleBlockInfo.java:
##########
@@ -27,14 +29,14 @@ public class ShuffleBlockInfo {
private int shuffleId;
private long crc;
private long taskAttemptId;
- private byte[] data;
+ private ByteBuf data;
private List<ShuffleServerInfo> shuffleServerInfos;
private int uncompressLength;
private long freeMemory;
public ShuffleBlockInfo(int shuffleId, int partitionId, long blockId, int
length, long crc,
- byte[] data, List<ShuffleServerInfo> shuffleServerInfos,
- int uncompressLength, int freeMemory, long taskAttemptId) {
+ ByteBuf data, List<ShuffleServerInfo> shuffleServerInfos,
+ int uncompressLength, long freeMemory, long taskAttemptId) {
this.partitionId = partitionId;
Review Comment:
We can keep the original constructor for tests and add a new constructor for
new implement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
