leixm commented on code in PR #742: URL: https://github.com/apache/incubator-uniffle/pull/742#discussion_r1142836611
########## common/src/main/java/org/apache/uniffle/common/netty/protocol/Encoders.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.uniffle.common.netty.protocol; + +import java.util.List; + +import io.netty.buffer.ByteBuf; + +import org.apache.uniffle.common.ShuffleBlockInfo; +import org.apache.uniffle.common.ShuffleServerInfo; +import org.apache.uniffle.common.util.ByteBufUtils; + +public class Encoders { + public static void encodeShuffleServerInfo(ShuffleServerInfo shuffleServerInfo, ByteBuf byteBuf) { + ByteBufUtils.writeLengthAndString(byteBuf, shuffleServerInfo.getId()); + ByteBufUtils.writeLengthAndString(byteBuf, shuffleServerInfo.getHost()); + byteBuf.writeInt(shuffleServerInfo.getGrpcPort()); + byteBuf.writeInt(shuffleServerInfo.getNettyPort()); + } + + public static void encodeShuffleBlockInfo(ShuffleBlockInfo shuffleBlockInfo, ByteBuf byteBuf) { + byteBuf.writeInt(shuffleBlockInfo.getPartitionId()); + byteBuf.writeLong(shuffleBlockInfo.getBlockId()); + byteBuf.writeInt(shuffleBlockInfo.getLength()); + byteBuf.writeInt(shuffleBlockInfo.getShuffleId()); + byteBuf.writeLong(shuffleBlockInfo.getCrc()); + byteBuf.writeLong(shuffleBlockInfo.getTaskAttemptId()); + ByteBufUtils.copyByteBuf(shuffleBlockInfo.getData(), byteBuf); Review Comment: > Do we need to release memory after copying here? > > ``` > shuffleBlockInfo.getData().release(). > ``` If ByteBuf uses heap memory, I think there is no need to manually call release and this part of memory will be reclaimed during gc. Secondly, there may be retries. The current encode does not mean that the request must be successful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
