xianjingfeng commented on code in PR #673:
URL: https://github.com/apache/incubator-uniffle/pull/673#discussion_r1144182340
##########
integration-test/common/src/test/java/org/apache/uniffle/test/QuorumTest.java:
##########
@@ -427,18 +431,25 @@ public void case3() throws Exception {
} catch (Exception e) {
assertTrue(e.getMessage().startsWith("Get shuffle result is failed"));
}
+ shuffleServers.set(1, createServer(1, tmpDir));
+ shuffleServers.get(1).start();
// When the timeout of one server is recovered, the block sending should
success
disableTimeout((MockedShuffleServer)shuffleServers.get(2));
report = shuffleWriteClientImpl.getShuffleResult("GRPC",
Sets.newHashSet(shuffleServerInfo0, shuffleServerInfo1,
shuffleServerInfo2),
testAppId, 0, 0);
assertEquals(report, blockIdBitmap);
+
}
@Test
public void case4() throws Exception {
String testAppId = "case4";
+ /** We must wait until server1 finish start, because {@link #case3} will
restart server1. */
+ await().timeout(10, TimeUnit.SECONDS).until(
+ () -> isPortAvailable(SHUFFLE_SERVER_PORT + 1));
+ Thread.sleep(500);
Review Comment:
I think I have solved this problem.
https://github.com/apache/incubator-uniffle/pull/673/commits/3020eb05d91c71736272029f521d102777520183
https://github.com/xianjingfeng/incubator-uniffle/actions/runs/4485510017
By the way, i found that this method was added by you, I think you should be
able to explain the underlying principle to me. @zuston
https://github.com/apache/incubator-uniffle/blob/5fd68764d6fc9e085c89f9ddabd62d99eea6163e/integration-test/common/src/test/java/org/apache/uniffle/test/MultiStorageFaultToleranceBase.java#L56
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
