advancedxy commented on code in PR #693:
URL: https://github.com/apache/incubator-uniffle/pull/693#discussion_r1149966880
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -265,6 +266,17 @@ public class RssSparkConfig {
+ " spark.rss.estimate.server.assignment.enabled"))
.createWithDefault(RssClientConfig.RSS_ESTIMATE_TASK_CONCURRENCY_PER_SERVER_DEFAULT_VALUE);
+ public static final ConfigEntry<Integer> RSS_SHUFFLE_MANAGER_GRPC_PORT =
createIntegerBuilder(
+ new ConfigBuilder(SPARK_RSS_CONFIG_PREFIX +
RssClientConf.SHUFFLE_MANAGER_GRPC_PORT.key())
+ .internal()
+ .doc(RssClientConf.SHUFFLE_MANAGER_GRPC_PORT.description())
+ ).createWithDefault(-1);
+
+ public static final ConfigEntry<Boolean> RSS_STAGE_RECOMPUTE =
createBooleanBuilder(
Review Comment:
This is only specific to Spark. So I don't think it's appropriate to put
this configuration into `RSSClientConf`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
