advancedxy commented on code in PR #811:
URL: https://github.com/apache/incubator-uniffle/pull/811#discussion_r1164022248
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/writer/WriteBufferManager.java:
##########
@@ -173,25 +174,27 @@ public List<ShuffleBlockInfo> addRecord(int partitionId,
Object key, Object valu
return null;
}
List<ShuffleBlockInfo> result = Lists.newArrayList();
- if (buffers.containsKey(partitionId)) {
- WriterBuffer wb = buffers.get(partitionId);
- if (wb.askForMemory(serializedDataLength)) {
+ synchronized (buffers) {
Review Comment:
I haven't found any better ways, I'm ok to accept it as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
