advancedxy commented on code in PR #891:
URL: https://github.com/apache/incubator-uniffle/pull/891#discussion_r1199896892
##########
common/src/main/java/org/apache/uniffle/common/util/RetryUtils.java:
##########
@@ -32,7 +32,7 @@ public static <T> T retry(RetryCmd<T> cmd, long intervalMs,
int retryTimes) thro
}
public static <T> T retry(RetryCmd<T> cmd, long intervalMs, int retryTimes,
- Set<Class> exceptionClasses) throws Throwable {
+ Set<Class<? extends Object>> exceptionClasses) throws Throwable {
Review Comment:
I believe `Class<? extends Throwable>` is preferred.
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/web/servlet/BaseServlet.java:
##########
@@ -44,9 +44,9 @@ protected void doPost(HttpServletRequest req,
HttpServletResponse resp) throws I
writeJSON(resp, handlerRequest(() -> handlePost(req, resp)));
}
- private Response handlerRequest(
- Callable<Response> function) {
- Response response;
+ private <T> Response<T> handlerRequest(
Review Comment:
It might be more suitable to make `BaseServlet` a generic class
`BaseServlet<T>`?
@xianjingfeng what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
