jerqi commented on PR #897: URL: https://github.com/apache/incubator-uniffle/pull/897#issuecomment-1559066174
> > According to you pr, could we use reflection to solve this incompatibility issues. For createRMContainerAllocator, we can use reflection to implement different methods for different version for Hadoop. We can refer to > > https://github.com/apache/incubator-uniffle/blob/9c62784f0115898a6f476ac58ac9a56dc8c915c3/client-spark/spark3/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java#L535 > > > > It seems similar about the method `createShuffleMetrics` > > Sure! we can use this way to solve this problem in spark's way. I also research the spark's way before, but may fall bak many times if many version are supported. It won't bring too much cost for the jobs. It's not critical path in the MapReduce. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
