cchung100m commented on code in PR #891:
URL: https://github.com/apache/incubator-uniffle/pull/891#discussion_r1205694173
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/web/servlet/BaseServlet.java:
##########
@@ -44,9 +44,9 @@ protected void doPost(HttpServletRequest req,
HttpServletResponse resp) throws I
writeJSON(resp, handlerRequest(() -> handlePost(req, resp)));
}
- private Response handlerRequest(
- Callable<Response> function) {
- Response response;
+ private <T> Response<T> handlerRequest(
Review Comment:
Hi @advancedxy @xianjingfeng
Thank you for sharing your thoughts and active feedback. I am open to
whether make `BaseServlet` a generic class or not. Willing to do the change if
we have a conclusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
