jerqi commented on code in PR #916:
URL: https://github.com/apache/incubator-uniffle/pull/916#discussion_r1212747669


##########
client-tez/src/test/java/org/apache/tez/common/RssTezUtilsTest.java:
##########
@@ -158,4 +163,25 @@ public void attemptTaskIdTest() {
     TezTaskAttemptID tezTaskAttemptID = 
TezTaskAttemptID.fromString(uniqueIdentifierToAttemptId);
     assertEquals(originalTezTaskAttemptID, tezTaskAttemptID);
   }
+
+  @Test
+  public void testParseRssWorker() {
+    Map<Integer, Set<ShuffleServerInfo>> rssWorker = new HashMap<>();
+    int shuffleId = 1001602;
+    String hostnameInfo = 
"localhost;1001602=172.19.193.152:19999+0_1_2_3,172.19.193.153:19999+2_3_4_5";

Review Comment:
   Could we add some test cases to verify the correctness of partition id?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to