jerqi commented on code in PR #922:
URL: https://github.com/apache/incubator-uniffle/pull/922#discussion_r1223743037
##########
client-tez/src/test/java/org/apache/tez/runtime/library/common/shuffle/impl/RssSimpleFetchedInputAllocatorTest.java:
##########
@@ -47,6 +46,7 @@ public void testAllocate() throws IOException {
float bufferPercent = 0.1f;
conf.setFloat(TezRuntimeConfiguration.TEZ_RUNTIME_SHUFFLE_FETCH_BUFFER_PERCENT,
bufferPercent);
conf.setFloat(TezRuntimeConfiguration.TEZ_RUNTIME_SHUFFLE_MEMORY_LIMIT_PERCENT,
1.0f);
+ String localDirs = "/tmp/" + this.getClass().getName();
Review Comment:
Could you use `TemporaryFolder` here? Because `TemporaryFolder` will be
deleted after test failed or finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
