yl09099 commented on code in PR #938:
URL: https://github.com/apache/incubator-uniffle/pull/938#discussion_r1225813158
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/ServerNode.java:
##########
@@ -110,8 +109,7 @@ public ServerNode(
this.eventNumInFlush = eventNumInFlush;
this.timestamp = System.currentTimeMillis();
this.tags = tags;
- this.isHealthy = isHealthy;
- this.status = status;
+ this.status = isHealthy ? status : ServerStatus.UNHEALTHY;
Review Comment:
Removing the isHealthy state here requires an RPC interface and many test
classes need to be modified. I intended to mention a separate PR to modify this
state so that the logic here is not too complicated.Just make sure, if you
think it needs to be changed here, I'll change it in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
