jerqi commented on code in PR #944: URL: https://github.com/apache/incubator-uniffle/pull/944#discussion_r1226479961
########## client-tez/src/main/java/org/apache/tez/runtime/library/output/RssUnorderedKVOutput.java: ########## @@ -0,0 +1,293 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.tez.runtime.library.output; + +import java.io.IOException; +import java.net.InetSocketAddress; +import java.security.PrivilegedExceptionAction; +import java.util.Collections; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.zip.Deflater; + +import com.google.common.base.Preconditions; +import com.google.common.collect.Lists; +import org.apache.hadoop.classification.InterfaceAudience; +import org.apache.hadoop.classification.InterfaceAudience.Public; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.ipc.RPC; +import org.apache.hadoop.mapred.JobConf; +import org.apache.hadoop.net.NetUtils; +import org.apache.hadoop.security.UserGroupInformation; +import org.apache.hadoop.yarn.api.records.ApplicationId; +import org.apache.tez.common.GetShuffleServerRequest; +import org.apache.tez.common.GetShuffleServerResponse; +import org.apache.tez.common.RssTezConfig; +import org.apache.tez.common.RssTezUtils; +import org.apache.tez.common.TezCommonUtils; +import org.apache.tez.common.TezRemoteShuffleUmbilicalProtocol; +import org.apache.tez.common.TezUtils; +import org.apache.tez.dag.api.TezConfiguration; +import org.apache.tez.dag.records.TezDAGID; +import org.apache.tez.dag.records.TezTaskAttemptID; +import org.apache.tez.dag.records.TezVertexID; +import org.apache.tez.runtime.api.AbstractLogicalOutput; +import org.apache.tez.runtime.api.Event; +import org.apache.tez.runtime.api.OutputContext; +import org.apache.tez.runtime.api.Writer; +import org.apache.tez.runtime.library.api.KeyValuesWriter; +import org.apache.tez.runtime.library.api.TezRuntimeConfiguration; +import org.apache.tez.runtime.library.common.MemoryUpdateCallbackHandler; +import org.apache.tez.runtime.library.common.shuffle.ShuffleUtils; +import org.apache.tez.runtime.library.common.sort.impl.ExternalSorter; +import org.apache.tez.runtime.library.common.sort.impl.RssTezPerPartitionRecord; +import org.apache.tez.runtime.library.common.sort.impl.RssUnSorter; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.apache.uniffle.common.ShuffleServerInfo; + + + +/** + * {@link RssUnorderedKVOutput} is an {@link AbstractLogicalOutput} which + * support remote shuffle. + * + */ +@Public +public class RssUnorderedKVOutput extends AbstractLogicalOutput { + + private static final Logger LOG = LoggerFactory.getLogger(RssUnorderedKVOutput.class); + protected ExternalSorter sorter; + protected Configuration conf; + protected MemoryUpdateCallbackHandler memoryUpdateCallbackHandler; + private long startTime; + private long endTime; + private final AtomicBoolean isStarted = new AtomicBoolean(false); + private final Deflater deflater; + private Map<Integer, List<ShuffleServerInfo>> partitionToServers; + private int mapNum; + private int numOutputs; + private TezTaskAttemptID taskAttemptId; + private ApplicationId applicationId; + private boolean sendEmptyPartitionDetails; + private OutputContext outputContext; + private String host; + private int port; + private String taskVertexName; + private String destinationVertexName; + private int shuffleId; + + public RssUnorderedKVOutput(OutputContext outputContext, int numPhysicalOutputs) { + super(outputContext, numPhysicalOutputs); + this.outputContext = outputContext; + this.deflater = TezCommonUtils.newBestCompressionDeflater(); + this.numOutputs = getNumPhysicalOutputs(); + this.mapNum = outputContext.getVertexParallelism(); + this.applicationId = outputContext.getApplicationId(); + this.taskAttemptId = TezTaskAttemptID.fromString( + RssTezUtils.uniqueIdentifierToAttemptId(outputContext.getUniqueIdentifier())); + this.taskVertexName = outputContext.getTaskVertexName(); + this.destinationVertexName = outputContext.getDestinationVertexName(); + LOG.info("taskAttemptId is {}", taskAttemptId.toString()); + LOG.info("taskVertexName is {}", taskVertexName); + LOG.info("destinationVertexName is {}", destinationVertexName); + LOG.info("Initialized RssUnorderedKVOutput."); + } + + private void getRssConf() { + try { + JobConf conf = new JobConf(RssTezConfig.RSS_CONF_FILE); + this.host = conf.get(RssTezConfig.RSS_AM_SHUFFLE_MANAGER_ADDRESS, "null host"); + this.port = conf.getInt(RssTezConfig.RSS_AM_SHUFFLE_MANAGER_PORT, -1); + LOG.info("Got RssConf am info : host is {}, port is {}", host, port); + + } catch (Exception e) { + LOG.warn("debugRssConf error: ", e); + } + } + + + @Override + public List<Event> initialize() throws Exception { + this.startTime = System.nanoTime(); + this.conf = TezUtils.createConfFromUserPayload(getContext().getUserPayload()); + this.memoryUpdateCallbackHandler = new MemoryUpdateCallbackHandler(); + + long memRequestSize = RssTezUtils.getInitialMemoryRequirement(conf, getContext().getTotalMemoryAvailableToTask()); + LOG.info("memRequestSize is {}", memRequestSize); + getContext().requestInitialMemory(memRequestSize, memoryUpdateCallbackHandler); + LOG.info("Got initialMemory."); + + getRssConf(); + + this.sendEmptyPartitionDetails = conf.getBoolean( + TezRuntimeConfiguration.TEZ_RUNTIME_EMPTY_PARTITION_INFO_VIA_EVENTS_ENABLED, + TezRuntimeConfiguration.TEZ_RUNTIME_EMPTY_PARTITION_INFO_VIA_EVENTS_ENABLED_DEFAULT); + + final InetSocketAddress address = NetUtils.createSocketAddrForHost(host, port); + + UserGroupInformation taskOwner = UserGroupInformation.createRemoteUser(this.applicationId.toString()); + + TezRemoteShuffleUmbilicalProtocol umbilical = taskOwner + .doAs(new PrivilegedExceptionAction<TezRemoteShuffleUmbilicalProtocol>() { + @Override + public TezRemoteShuffleUmbilicalProtocol run() throws Exception { + return RPC.getProxy(TezRemoteShuffleUmbilicalProtocol.class, + TezRemoteShuffleUmbilicalProtocol.versionID, + address, + conf); + } + }); + TezVertexID tezVertexID = taskAttemptId.getTaskID().getVertexID(); + TezDAGID tezDAGID = tezVertexID.getDAGId(); + this.shuffleId = RssTezUtils.computeShuffleId(tezDAGID.getId(), this.taskVertexName, this.destinationVertexName); + GetShuffleServerRequest request = new GetShuffleServerRequest(this.taskAttemptId, this.mapNum, + this.numOutputs, this.shuffleId); + + GetShuffleServerResponse response = umbilical.getShuffleAssignments(request); + this.partitionToServers = response.getShuffleAssignmentsInfoWritable() + .getShuffleAssignmentsInfo().getPartitionToServers(); + + LOG.info("Got response from am."); + return Collections.emptyList(); + } + + @Override + public void handleEvents(List<Event> list) { + + } + + @Override + public List<Event> close() throws Exception { + List<Event> returnEvents = Lists.newLinkedList(); + if (sorter != null) { + sorter.flush(); + sorter.close(); + this.endTime = System.nanoTime(); + returnEvents.addAll(generateEvents()); + sorter = null; + } else { + LOG.warn(getContext().getDestinationVertexName() + + ": Attempting to close output {} of type {} before it was started. " + + "Generating empty events", + getContext().getDestinationVertexName(), this.getClass().getSimpleName()); + returnEvents = generateEmptyEvents(); + } + LOG.info("RssUnOrderedKVOutput close."); + return returnEvents; + } + + @Override + public void start() throws Exception { + if (!isStarted.get()) { + memoryUpdateCallbackHandler.validateUpdateReceived(); + sorter = new RssUnSorter(taskAttemptId, getContext(), conf, mapNum, numOutputs, + memoryUpdateCallbackHandler.getMemoryAssigned(), shuffleId, + partitionToServers); + LOG.info("Initialized RssUnSorter."); + isStarted.set(true); + } + } + + @Override + public Writer getWriter() throws Exception { + Preconditions.checkState(isStarted.get(), "Cannot get writer before starting the Output"); + return new KeyValuesWriter() { + @Override + public void write(Object key, Iterable<Object> values) throws IOException { + sorter.write(key, values); + } + + @Override + public void write(Object key, Object value) throws IOException { + sorter.write(key, value); + } + }; + } + + private List<Event> generateEvents() throws IOException { + List<Event> eventList = Lists.newLinkedList(); + boolean isLastEvent = true; + + String auxiliaryService = conf.get(TezConfiguration.TEZ_AM_SHUFFLE_AUXILIARY_SERVICE_ID, + TezConfiguration.TEZ_AM_SHUFFLE_AUXILIARY_SERVICE_ID_DEFAULT); + + int[] numRecordsPerPartition = ((RssUnSorter) sorter).getNumRecordsPerPartition(); + + RssTezPerPartitionRecord rssTezSpillRecord = new RssTezPerPartitionRecord(numOutputs, numRecordsPerPartition); Review Comment: Could we rename this variable to remove the word `rssTezSpillRecord`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
