jerqi commented on code in PR #950:
URL: https://github.com/apache/incubator-uniffle/pull/950#discussion_r1229108486
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/writer/WriteBufferManager.java:
##########
@@ -128,7 +128,11 @@ public WriteBufferManager(
super(taskMemoryManager, taskMemoryManager.pageSizeBytes(),
MemoryMode.ON_HEAP);
this.bufferSize = bufferManagerOptions.getBufferSize();
this.spillSize = bufferManagerOptions.getBufferSpillThreshold();
- this.instance = serializer.newInstance();
+ // columnar shuffle reader use the serialized data directly
Review Comment:
The serializer is null when we use columnar shuffle, isn't it? Could we add
a new test case that the serializer is null.
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/reader/RssShuffleReader.java:
##########
@@ -208,10 +208,7 @@ public Configuration getHadoopConf() {
MultiPartitionIterator() {
List<CompletionIterator<Product2<K, C>, RssShuffleDataIterator<K, C>>>
iterators = Lists.newArrayList();
Review Comment:
if the condition satisfy `rssShuffleHandle.getNumMaps() <= 0`, we should
return iterators directly in my opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
