Kwafoor commented on code in PR #931:
URL: https://github.com/apache/incubator-uniffle/pull/931#discussion_r1230335584
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/access/checker/AbstractAccessChecker.java:
##########
@@ -25,6 +25,11 @@
public abstract class AbstractAccessChecker implements AccessChecker {
protected AbstractAccessChecker(AccessManager accessManager) throws
Exception {
-
+
+ }
+
+ @Override
+ public void refreshAccessChecker() {
Review Comment:
> Could we make it as an abstract method?
Changing refreshAccessChecker to an abstract method and requiring all
classes that inherit from AbstractAccessChecker to implement, it is not
appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
