yl09099 commented on code in PR #938:
URL: https://github.com/apache/incubator-uniffle/pull/938#discussion_r1231889463
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/web/servlet/NodesServlet.java:
##########
@@ -37,10 +38,17 @@ public NodesServlet(CoordinatorServer coordinator) {
}
@Override
- protected Response<List<ServerNode>> handleGet(HttpServletRequest req,
HttpServletResponse resp) {
- List<ServerNode> serverList =
coordinator.getClusterManager().getServerList(Collections.EMPTY_SET);
+ protected Response handleGet(HttpServletRequest req, HttpServletResponse
resp) {
+ List<ServerNode> serverList;
String id = req.getParameter("id");
String status = req.getParameter("status");
+ if (status != null &&
status.equalsIgnoreCase(ServerStatus.UNHEALTHY.name())) {
Review Comment:
If the status parameter is not passed in the URL, status.equalsignorecase
will raise a null pointer exception, but we are allowed not to pass the status
parameter when the active state is present
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
