lifeSo opened a new issue, #1062:
URL: https://github.com/apache/incubator-uniffle/issues/1062

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the 
[issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### Describe the bug
   
   when there is no task fail and attempt, the default IdHelper code before 
will work ok, but if where is task fail and attempt, it will filter  block id.
   
   The filter code:
   - ShuffleReadClientImp.java
   
   ```
       List<Long> removeBlockIds = Lists.newArrayList();
       blockIdBitmap.forEach(
           bid -> {
             if (!taskIdBitmap.contains(idHelper.getTaskAttemptId(bid))) {
               removeBlockIds.add(bid);
             }
           });
   
       for (long rid : removeBlockIds) {
         blockIdBitmap.removeLong(rid);
       }
   ```
   
   
   idHelper.getTaskAttemptId(bid) will return wrong task attemt id if there is 
task attempt and use default idHelper.
   
   ### Affects Version(s)
   
   master
   
   ### Uniffle Server Log Output
   
   _No response_
   
   ### Uniffle Engine Log Output
   
   _No response_
   
   ### Uniffle Server Configurations
   
   _No response_
   
   ### Uniffle Engine Configurations
   
   _No response_
   
   ### Additional context
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to