zuston commented on issue #1119: URL: https://github.com/apache/incubator-uniffle/issues/1119#issuecomment-1669042080
BTW. the code of https://github.com/apache/incubator-uniffle/blob/ca245316c3f5002de117adb7f550d3198fb7f6e2/server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java#L410-L440 looks strange. It's better to throw `NoBufferException` or `NoRegisterException` instead of using the negative number to indicate the error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
