bin41215 commented on code in PR #1125:
URL: 
https://github.com/apache/incubator-uniffle/pull/1125#discussion_r1288362676


##########
docs/client_guide.md:
##########
@@ -241,7 +241,8 @@ Notice: this feature requires the MEMORY_LOCAL_HADOOP mode.
 | Property Name                  | Default | Description                       
                                      |
 
|--------------------------------|---------|-------------------------------------------------------------------------|
 | tez.rss.avoid.recompute.succeeded.task | false   | Whether to avoid 
recompute succeeded task when node is unhealthy or black-listed |
- 
+| tez.rss.client.max.buffer.size | 3k | The max buffer size in map side |

Review Comment:
   ok.



##########
docs/client_guide.md:
##########
@@ -241,7 +241,8 @@ Notice: this feature requires the MEMORY_LOCAL_HADOOP mode.
 | Property Name                  | Default | Description                       
                                      |
 
|--------------------------------|---------|-------------------------------------------------------------------------|
 | tez.rss.avoid.recompute.succeeded.task | false   | Whether to avoid 
recompute succeeded task when node is unhealthy or black-listed |
- 
+| tez.rss.client.max.buffer.size | 3k | The max buffer size in map side |

Review Comment:
   rss.client.max.buffer.size  -->  maxSegmentSize -->  This parameter is the 
size of the WrappedBuffer created
   rss.writer.buffer.size      -->  maxBufferSize  -->  When 
buffer.getDataLength > maxBufferSize, the buffer will be sent to the server
   This logic is a reuse of MapReduce.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to