zhengchenyu commented on code in PR #1131:
URL:
https://github.com/apache/incubator-uniffle/pull/1131#discussion_r1290940489
##########
client-mr/core/src/main/java/org/apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java:
##########
@@ -111,20 +113,32 @@ public RssMRAppMaster(
rssNmHttpPort = nmHttpPort;
rssContainerID = containerId;
rssContainerAllocator = null;
+ shuffleWriteClient = client;
}
private static final Logger LOG =
LoggerFactory.getLogger(RssMRAppMaster.class);
+ @Override
+ protected void serviceStop() throws Exception {
Review Comment:
Yes! In general, this will be invoked explicitly.
Below is the steps:
(1)
KillNewJobTransition/CommitSucceededTransition/InternalTerminationTransition =>
job.finished
(2) In job.finished, send JobFinishEvent
(3) JobFinishEventHandler handle the JobFinishEvent and called shutDownJob
(4) shutDownJob => MRAppMaster.this.stop() => serviceStop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
