jerqi commented on code in PR #1113:
URL:
https://github.com/apache/incubator-uniffle/pull/1113#discussion_r1293381923
##########
.github/workflows/build.yml:
##########
@@ -91,3 +96,36 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs
-DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout project
+ uses: actions/checkout@v3
+ - name: Set up JDK ${{ env.java-version }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ env.java-version }}
+ distribution: ${{ env.jdk-distro }}
+ - name: Cache local Maven repository
+ if: ${{ env.cache-key != '' }}
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: mvn-${{ env.java-version }}-${{ env.cache-key }}-${{
hashFiles('**/pom.xml') }}
+ restore-keys: |
+ mvn-${{ env.java-version }}-${{ env.cache-key }}-
+ - name: Set up Go ${{ env.go-version }}
+ if: ${{ env.go-version != '' }}
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ env.go-version }}
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
+ run: |
+ chmod +x ./deploy/kubernetes/integration-test/e2e/start-e2e.sh
+ set -e
Review Comment:
This is unnecessary. We have set the variable in the `start-e2e.sh`.
![Uploading 企业微信截图_2150d112-bb7b-48bf-b74d-ebb6e00900e4.png…]()
##########
.github/workflows/build.yml:
##########
@@ -91,3 +96,36 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs
-DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout project
+ uses: actions/checkout@v3
+ - name: Set up JDK ${{ env.java-version }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ env.java-version }}
+ distribution: ${{ env.jdk-distro }}
+ - name: Cache local Maven repository
+ if: ${{ env.cache-key != '' }}
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: mvn-${{ env.java-version }}-${{ env.cache-key }}-${{
hashFiles('**/pom.xml') }}
+ restore-keys: |
+ mvn-${{ env.java-version }}-${{ env.cache-key }}-
+ - name: Set up Go ${{ env.go-version }}
+ if: ${{ env.go-version != '' }}
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ env.go-version }}
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
+ run: |
+ chmod +x ./deploy/kubernetes/integration-test/e2e/start-e2e.sh
+ set -e
Review Comment:
This is unnecessary. We have set the variable in the `start-e2e.sh`.
![Uploading 企业微信截图_2150d112-bb7b-48bf-b74d-ebb6e00900e4.png…]()
##########
.github/workflows/build.yml:
##########
@@ -91,3 +96,36 @@ jobs:
maven-args: package -Pkubernetes -DskipUTs -DskipITs
-DskipBuildImage=${{ needs.changes.outputs.rss_server_docker == 'false' }}
cache-key: package
go-version: '1.17'
+
+ kubernetes-integration:
+ needs: [kubernetes]
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Checkout project
+ uses: actions/checkout@v3
+ - name: Set up JDK ${{ env.java-version }}
+ uses: actions/setup-java@v3
+ with:
+ java-version: ${{ env.java-version }}
+ distribution: ${{ env.jdk-distro }}
+ - name: Cache local Maven repository
+ if: ${{ env.cache-key != '' }}
+ uses: actions/cache@v3
+ with:
+ path: ~/.m2/repository
+ key: mvn-${{ env.java-version }}-${{ env.cache-key }}-${{
hashFiles('**/pom.xml') }}
+ restore-keys: |
+ mvn-${{ env.java-version }}-${{ env.cache-key }}-
+ - name: Set up Go ${{ env.go-version }}
+ if: ${{ env.go-version != '' }}
+ uses: actions/setup-go@v3
+ with:
+ go-version: ${{ env.go-version }}
+ - name: Compile kubernetes operator
+ run: |
+ mvn package -Pkubernetes -DskipTests
+ - name: Run local Integration Tests
+ run: |
+ chmod +x ./deploy/kubernetes/integration-test/e2e/start-e2e.sh
+ set -e
Review Comment:
This is unnecessary. We have set the variable in the `start-e2e.sh`.
<img width="504" alt="企业微信截图_2150d112-bb7b-48bf-b74d-ebb6e00900e4"
src="https://github.com/apache/incubator-uniffle/assets/8159038/1f273906-93c4-43c6-a762-32bdd107fa45";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
