zuston commented on PR #637:
URL:
https://github.com/apache/incubator-uniffle/pull/637#issuecomment-1678583548
> > Will the broadcast be cleaned when the shuffle is removed?
>
> yes. it's registered for cleanup when sparkcontext creates a new broadcast
variable. However, the cleaner may not clean it immediately just like below
unregisterShuffle method. The cleaner gets chance to capture them (shuffle,
broadcast...) only after GC happened. This behavior is good for this broadcast
variable since it's small anyway. Will it cause problem in below code snippet?
shuffle server may not get cleaned up quickly if there is no right GC in driver.
>
> `@Override public boolean unregisterShuffle(int shuffleId) { try { if
(SparkEnv.get().executorId().equals("driver")) {
shuffleWriteClient.unregisterShuffle(appId, shuffleId); } } catch (Exception e)
{ LOG.warn("Errors on unregister to remote shuffle-servers", e); } return true;
}`
I don't see the logic of destroy the broadcast var explicitly. Do we need to
destroy it in the `unregisterShuffle` method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
