xumanbu commented on code in PR #1186:
URL:
https://github.com/apache/incubator-uniffle/pull/1186#discussion_r1314917088
##########
coordinator/src/test/java/org/apache/uniffle/coordinator/QuotaManagerTest.java:
##########
@@ -116,13 +116,15 @@ public void testCheckQuota() throws Exception {
final boolean icCheck =
applicationManager.getQuotaManager().checkQuota("user4",
String.valueOf(i1));
registerThread.join();
- assertTrue(icCheck);
+ assertFalse(icCheck);
Review Comment:
I'll keep current testCheckQuota logic for test
`rss.coordinator.quota.default.app.num = 5`, add a new
`testCheckQuotaWithDefault` function to test default value -1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
