xianjingfeng opened a new issue, #1247:
URL: https://github.com/apache/incubator-uniffle/issues/1247

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the 
[issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### Describe the bug
   
   I found some shuffle servers in our cluster write shuffle data to HDFS 
frequently. And then i found the size stored in `LocalStorageMeta` is incorrect.
   Maybe we should update the metrics in the following method. There may be 
other places that have been missed.
   
https://github.com/apache/incubator-uniffle/blob/b2154c722f30ee31a867561f550254842c33cbab/server/src/main/java/org/apache/uniffle/server/storage/LocalStorageManager.java#L346
   
   Other suggestion:
   1. Maybe is not a good way that judging if the local disk can be written by 
using this metric, because this metric is easily overlooked and it is hard to 
guarantee it's accurate. And #1071 trying to change this.
   2. I found `shuffleMetaMap` in `LocalStorageMeta` is useless, maybe we 
should remove it. And then we can remove `LocalStorageMeta` at the same time.
   
   ### Affects Version(s)
   
   master
   
   ### Uniffle Server Log Output
   
   _No response_
   
   ### Uniffle Engine Log Output
   
   _No response_
   
   ### Uniffle Server Configurations
   
   _No response_
   
   ### Uniffle Engine Configurations
   
   _No response_
   
   ### Additional context
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to