zhengchenyu commented on code in PR #1250:
URL:
https://github.com/apache/incubator-uniffle/pull/1250#discussion_r1366402009
##########
client-tez/src/main/java/org/apache/tez/runtime/library/common/shuffle/impl/RssSimpleFetchedInputAllocator.java:
##########
@@ -150,9 +202,26 @@ public synchronized FetchedInput allocate(
long actualSize, long compressedSize, InputAttemptIdentifier
inputAttemptIdentifier)
throws IOException {
if (actualSize > maxSingleShuffleLimit || this.usedMemory + actualSize >
this.memoryLimit) {
- LOG.info("Allocate DiskFetchedInput, length:{}", actualSize);
- return new DiskFetchedInput(
- actualSize + 8, inputAttemptIdentifier, this, conf,
localDirAllocator, fileNameAllocator);
+ if (remoteSpillEnable) {
+ LOG.info("Allocate RemoteFetchedInput, length:{}", actualSize);
+ return new RemoteFetchedInput(
+ actualSize + 8,
+ inputAttemptIdentifier,
+ this,
+ remoteFS,
+ remoteSpillBasePath,
+ uniqueIdentifier,
+ appAttemptId);
+ } else {
+ LOG.info("Allocate DiskFetchedInput, length:{}", actualSize);
+ return new DiskFetchedInput(
+ actualSize + 8,
Review Comment:
OK, I will do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
