jerqi commented on code in PR #1260:
URL:
https://github.com/apache/incubator-uniffle/pull/1260#discussion_r1369485722
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java:
##########
@@ -211,7 +212,7 @@ private boolean sendShuffleDataAsync(
.forEach(
blockId ->
blockIdsSendFailTracker
- .computeIfAbsent(blockId, id ->
Lists.newArrayList())
+ .computeIfAbsent(blockId, id -> new
CopyOnWriteArrayList())
Review Comment:
`CopyOnWriteArrayList` is suitable for the situation that we have more read
operations than write operations. But we have more write operations than read
operations. Maybe it will give us performance regression. If we want to use
thread safe collection, maybe queue will be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
