jerqi commented on code in PR #1146:
URL:
https://github.com/apache/incubator-uniffle/pull/1146#discussion_r1377409006
##########
client-spark/common/src/main/java/org/apache/uniffle/shuffle/manager/ShuffleManagerGrpcService.java:
##########
@@ -230,6 +231,38 @@ public void getPartitionToShufflerServer(
responseObserver.onCompleted();
}
+ @Override
+ public void reallocationShuffleServers(
+ RssProtos.ReallocationServersRequest request,
+ StreamObserver<RssProtos.ReallocationServersReponse> responseObserver) {
+ int stageId = request.getStageId();
+ int stageAttemptNumber = request.getStageAttemptNumber();
+ int shuffleId = request.getShuffleId();
+ int numPartitions = request.getNumPartitions();
+ boolean reallocationFlag =
+ shuffleManager.reShuffleAssignments(stageId, stageAttemptNumber,
shuffleId, numPartitions);
+ /**
+ * If the shuffleServer is reassigned, we need to clear the metadata of
the completed Task,
+ * otherwise some of the Stage's data will be lost
+ */
+ if (reallocationFlag) {
Review Comment:
`reallocation` -> `needReassign` ?
##########
client-spark/common/src/main/java/org/apache/uniffle/shuffle/manager/ShuffleManagerGrpcService.java:
##########
@@ -230,6 +231,38 @@ public void getPartitionToShufflerServer(
responseObserver.onCompleted();
}
+ @Override
+ public void reallocationShuffleServers(
Review Comment:
`reallocationShuffleServers` -> `reassignShuffleServers`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
