yl09099 commented on code in PR #1147:
URL:
https://github.com/apache/incubator-uniffle/pull/1147#discussion_r1386104989
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java:
##########
@@ -473,4 +492,61 @@ Map<Integer, Set<Long>> getPartitionToBlockIds() {
public WriteBufferManager getBufferManager() {
return bufferManager;
}
+
+ private static ShuffleManagerClient createShuffleManagerClient(String host,
int port)
+ throws IOException {
+ ClientType grpc = ClientType.GRPC;
+ // Host can be inferred from `spark.driver.bindAddress`, which would be
set when SparkContext is
+ // constructed.
+ return
ShuffleManagerClientFactory.getInstance().createShuffleManagerClient(grpc,
host, port);
Review Comment:
> Can we reduce the number of ShuffleManagerClient creations?
I wrote it in the way that Read failed, and I will fix it together in the
next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
