leixm commented on code in PR #1313:
URL:
https://github.com/apache/incubator-uniffle/pull/1313#discussion_r1393747911
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleReadClientImpl.java:
##########
@@ -258,7 +262,10 @@ protected Roaring64NavigableMap getProcessedBlockIds() {
private int read() {
long start = System.currentTimeMillis();
- ShuffleDataResult sdr = clientReadHandler.readShuffleData();
+ if (sdr != null) {
Review Comment:
In order to avoid a copy, we postponed the release here, and
`RssUtils.releaseByteBuffer(readBuffer)` cannot actually release the memory,
because PlatformDependent.freeDirectBuffer can only release the ByteBuffer of
`withCleaner`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
