wenlongbrother commented on code in PR #1311:
URL:
https://github.com/apache/incubator-uniffle/pull/1311#discussion_r1398995333
##########
rust/experimental/server/src/store/memory.rs:
##########
@@ -416,7 +423,15 @@ impl Store for MemoryStore {
}
}
- self.read_partial_data_with_max_size_limit(candidate_blocks,
max_size)
+ self.read_partial_data_with_max_size_limit_and_filter(
+ candidate_blocks,
+ max_size,
+ if last_block_id == -1 {
+ None
Review Comment:
You mentioned
```
Otherwise, when the last_block_id = -1, the filter is not valid. This case
also should be added into test.
```
I may misunderstood you, let me update it, sorry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
