zuston commented on code in PR #1362:
URL:
https://github.com/apache/incubator-uniffle/pull/1362#discussion_r1420082114
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServer.java:
##########
@@ -311,6 +311,7 @@ private void initMetricsReporter() throws Exception {
if (metricReporter != null) {
metricReporter.addCollectorRegistry(ShuffleServerMetrics.getCollectorRegistry());
metricReporter.addCollectorRegistry(grpcMetrics.getCollectorRegistry());
+ metricReporter.addCollectorRegistry(nettyMetrics.getCollectorRegistry());
Review Comment:
It won't be null, the nettyMetrics always will be initialized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
