zuston commented on code in PR #1363:
URL:
https://github.com/apache/incubator-uniffle/pull/1363#discussion_r1423722351
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerMetrics.java:
##########
@@ -72,7 +72,7 @@ public class ShuffleServerMetrics {
private static final String IN_FLUSH_BUFFER_SIZE = "in_flush_buffer_size";
private static final String USED_BUFFER_SIZE = "used_buffer_size";
private static final String READ_USED_BUFFER_SIZE = "read_used_buffer_size";
- private static final String USED_DIRECT_MEMORY_SIZE =
"used_direct_memory_size";
+ private static final String NETTY_USED_DIRECT_MEMORY_SIZE =
"netty_used_direct_memory_size";
Review Comment:
And this should be initialized in the netty metrics class rather than in
`shuffleServer` class
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerMetrics.java:
##########
@@ -72,7 +72,7 @@ public class ShuffleServerMetrics {
private static final String IN_FLUSH_BUFFER_SIZE = "in_flush_buffer_size";
private static final String USED_BUFFER_SIZE = "used_buffer_size";
private static final String READ_USED_BUFFER_SIZE = "read_used_buffer_size";
- private static final String USED_DIRECT_MEMORY_SIZE =
"used_direct_memory_size";
+ private static final String NETTY_USED_DIRECT_MEMORY_SIZE =
"netty_used_direct_memory_size";
Review Comment:
This metrics also should be moved into netty metric class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
