jerqi commented on code in PR #1370:
URL:
https://github.com/apache/incubator-uniffle/pull/1370#discussion_r1425586987
##########
common/src/main/java/org/apache/uniffle/common/config/RssClientConf.java:
##########
@@ -142,4 +142,12 @@ public class RssClientConf {
.enumType(ClientType.class)
.defaultValue(ClientType.GRPC)
.withDescription("Supports GRPC, GRPC_NETTY");
+
+ public static final ConfigOption<Boolean>
RSS_CLIENT_REMOTE_STORAGE_USE_LOCAL_CONF_ENABLED =
+ ConfigOptions.key("rss.client.remote.storage.use-local-conf.enabled")
Review Comment:
Could we use 4 levels + camel naming style? This is the style of Spark. This
will avoid too many levels.
For example:
`rss.client.remote.storage.useLocalConfAsDefault`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
