zuston commented on code in PR #1365:
URL:
https://github.com/apache/incubator-uniffle/pull/1365#discussion_r1426418520
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -72,29 +72,35 @@ public class RssSparkConfig {
SPARK_RSS_CONFIG_PREFIX +
RssClientConfig.RSS_PARTITION_NUM_PER_RANGE))
.createWithDefault(RssClientConfig.RSS_PARTITION_NUM_PER_RANGE_DEFAULT_VALUE);
- public static final ConfigEntry<String> RSS_WRITER_BUFFER_SIZE =
- createStringBuilder(
- new ConfigBuilder(SPARK_RSS_CONFIG_PREFIX +
RssClientConfig.RSS_WRITER_BUFFER_SIZE)
- .doc("Buffer size for single partition data"))
- .createWithDefault("3m");
-
- public static final ConfigEntry<String> RSS_WRITER_SERIALIZER_BUFFER_SIZE =
- createStringBuilder(new
ConfigBuilder("spark.rss.writer.serializer.buffer.size"))
- .createWithDefault("3k");
-
- public static final ConfigEntry<String> RSS_WRITER_BUFFER_SEGMENT_SIZE =
- createStringBuilder(new
ConfigBuilder("spark.rss.writer.buffer.segment.size"))
- .createWithDefault("3k");
-
- public static final ConfigEntry<String> RSS_WRITER_BUFFER_SPILL_SIZE =
- createStringBuilder(
- new ConfigBuilder("spark.rss.writer.buffer.spill.size")
- .doc("Buffer size for total partition data"))
- .createWithDefault("128m");
-
- public static final ConfigEntry<String> RSS_WRITER_PRE_ALLOCATED_BUFFER_SIZE
=
- createStringBuilder(new
ConfigBuilder("spark.rss.writer.pre.allocated.buffer.size"))
- .createWithDefault("16m");
+ public static final ConfigOption<String> RSS_WRITER_BUFFER_SIZE =
Review Comment:
This change is not correct, Please follow this example.
```
public static final ConfigOption<Long> RSS_CLIENT_SEND_SIZE_LIMITATION =
ConfigOptions.key("rss.client.send.size.limit")
.longType()
.defaultValue(1024 * 1024 * 16L)
.withDescription("The max data size sent to shuffle server");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
