lifeSo commented on code in PR #1389:
URL:
https://github.com/apache/incubator-uniffle/pull/1389#discussion_r1432500226
##########
common/src/main/java/org/apache/uniffle/common/util/JavaUtils.java:
##########
@@ -22,13 +22,26 @@
import java.util.concurrent.ConcurrentHashMap;
import java.util.function.Function;
+import com.google.common.base.Enums;
import org.apache.commons.lang3.JavaVersion;
import org.apache.commons.lang3.SystemUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
public class JavaUtils {
private static final Logger logger =
LoggerFactory.getLogger(JavaUtils.class);
+ private static final String JAVA_9 = "JAVA_9";
+
+ public static boolean isJavaVersionAtLeastJava9() {
+ if (Enums.getIfPresent(JavaVersion.class, JAVA_9).isPresent()
+ && SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9)) {
+ logger.info("Jdk version is at least jdk9");
Review Comment:
Ok, I removed it.
##########
common/src/main/java/org/apache/uniffle/common/util/JavaUtils.java:
##########
@@ -22,13 +22,26 @@
import java.util.concurrent.ConcurrentHashMap;
import java.util.function.Function;
+import com.google.common.base.Enums;
import org.apache.commons.lang3.JavaVersion;
import org.apache.commons.lang3.SystemUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
public class JavaUtils {
private static final Logger logger =
LoggerFactory.getLogger(JavaUtils.class);
+ private static final String JAVA_9 = "JAVA_9";
+
+ public static boolean isJavaVersionAtLeastJava9() {
+ if (Enums.getIfPresent(JavaVersion.class, JAVA_9).isPresent()
+ && SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9)) {
+ logger.info("Jdk version is at least jdk9");
+ return true;
+ } else {
+ logger.info("Jdk version is jdk8");
Review Comment:
Ok, I removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
