zuston commented on code in PR #1393:
URL:
https://github.com/apache/incubator-uniffle/pull/1393#discussion_r1439286963
##########
integration-test/common/src/test/java/org/apache/uniffle/test/IntegrationTestBase.java:
##########
@@ -58,6 +58,8 @@ public abstract class IntegrationTestBase extends
HadoopTestBase {
protected static final int JETTY_PORT_1 = 19998;
protected static final int JETTY_PORT_2 = 20040;
protected static final String COORDINATOR_QUORUM = LOCALHOST + ":" +
COORDINATOR_PORT_1;
+ protected static final String SHUFFLE_SERVER_METRICS_URL =
Review Comment:
why need this?
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerMetrics.java:
##########
@@ -80,7 +80,9 @@ public class ShuffleServerMetrics {
private static final String LOCAL_DISK_PATH_LABEL = "local_disk_path";
public static final String LOCAL_DISK_PATH_LABEL_ALL = "ALL";
private static final String TOTAL_REQUIRE_BUFFER_FAILED =
"total_require_buffer_failed";
- private static final String TOTAL_REQUIRE_BUFFER_FAILED_FOR_HUGE_PARTITION =
+ private static final String TOTAL_REQUIRE_BUFFER_FAILED_FOR_NO_REGISTER =
Review Comment:
this is not related with this PR. Right?
##########
common/src/main/java/org/apache/uniffle/common/rpc/StatusCode.java:
##########
@@ -27,13 +27,14 @@ public enum StatusCode {
SUCCESS(0),
DOUBLE_REGISTER(1),
NO_BUFFER(2),
- INVALID_STORAGE(3),
- NO_REGISTER(4),
- NO_PARTITION(5),
- INTERNAL_ERROR(6),
- TIMEOUT(7),
- ACCESS_DENIED(8),
- INVALID_REQUEST(9),
+ NO_BUFFER_FOR_HUGE_PARTITION(3),
Review Comment:
+1. should be 11
##########
internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/ShuffleServerGrpcClient.java:
##########
@@ -223,7 +223,8 @@ public long requirePreAllocation(
long result = FAILED_REQUIRE_ID;
Random random = new Random();
final int backOffBase = 2000;
- while (rpcResponse.getStatus() == RssProtos.StatusCode.NO_BUFFER) {
+ while (rpcResponse.getStatus() == RssProtos.StatusCode.NO_BUFFER
+ || rpcResponse.getStatus() ==
RssProtos.StatusCode.NO_BUFFER_FOR_HUGE_PARTITION) {
Review Comment:
Could you expose the concrete status code into log message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
