rickyma commented on code in PR #1411:
URL:
https://github.com/apache/incubator-uniffle/pull/1411#discussion_r1443811095
##########
internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/ShuffleServerGrpcNettyClient.java:
##########
@@ -154,7 +155,7 @@ public RssSendShuffleDataResponse
sendShuffleData(RssSendShuffleDataRequest requ
maxRetryAttempts,
t -> !(t instanceof OutOfMemoryError));
} catch (Throwable throwable) {
- LOG.warn(throwable.getMessage());
+ LOG.warn(ExceptionUtils.getStackTrace(throwable));
Review Comment:
Because `LOG.warn` does not accept an exception type parameter, it only
accepts a string.
As I mentioned above, I use `ExceptionUtils.getStackTrace(e)` just for the
sake of minimal code changes and simplicity.
If you prefer using `throwable` directly, I will change it like below:
`LOG.warn("Failed to send shuffle data due to ", throwable);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
