lifeSo commented on code in PR #1413:
URL:
https://github.com/apache/incubator-uniffle/pull/1413#discussion_r1445750557
##########
client-tez/src/test/java/org/apache/tez/dag/app/TezRemoteShuffleManagerTest.java:
##########
@@ -224,7 +227,12 @@ public void testTezRemoteShuffleManagerSecure() {
secretManager.addTokenForJob(tokenIdentifier, sessionToken);
TezRemoteShuffleManager tezRemoteShuffleManager =
new TezRemoteShuffleManager(
- appId.toString(), sessionToken, conf, appId.toString(), client,
null);
+ appId.toString(),
+ sessionToken,
+ new TezClientConf(conf),
Review Comment:
I think there needs a way to init and read configuration, like:
```
public ShuffleServerConf(String fileName) {
super();
boolean ret = loadConfFromFile(fileName);
if (!ret) {
throw new IllegalStateException("Fail to load config file " +
fileName);
}
}
```
```
public DashboardConf(String fileName) {
super();
boolean ret = loadConfFromFile(fileName);
if (!ret) {
throw new IllegalStateException("Fail to load config file " +
fileName);
}
}
```
```
public CoordinatorConf(String fileName) {
super();
boolean ret = loadConfFromFile(fileName);
if (!ret) {
throw new IllegalStateException("Fail to load config file " +
fileName);
}
}
```
And the only difference is TezClientConf init from configuration。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
