zuston opened a new issue, #1428:
URL: https://github.com/apache/incubator-uniffle/issues/1428

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the 
[issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### Describe the bug
   
   I specify the following conf.
   
   ```
   # HDFS fallback strategy
   rss.server.hybrid.storage.fallback.strategy.class       
org.apache.uniffle.server.storage.LocalStorageManagerFallbackStrategy
   rss.server.hybrid.storage.manager.selector.class        
org.apache.uniffle.server.storage.hybrid.HugePartitionSensitiveStorageManagerSelector
   ```
   
   
   For one shuffle-server, fallback to hadoop storage is  invalid when local 
storage's all disks are in high watermark.
   
   Because once all disks are in high-watermark, it will return null in 
selectStorage, and because the retry time default value is 0 in 
`LocalStorageManagerFallbackStrategy`. So it won't be fallbacked and then the 
event will be discarded in `DefaultFlushEventHandler`.
   
   I will fix this using the following 2 steps
   1. allow setting the negative value for 
`rss.server.hybrid.storage.fallback.max.fail.times`
   2. optimize `DefaultFlushEventHandler` when encountering null storage for 
one flush event. 
   
   ### Affects Version(s)
   
   master
   
   ### Uniffle Server Log Output
   
   _No response_
   
   ### Uniffle Engine Log Output
   
   _No response_
   
   ### Uniffle Server Configurations
   
   _No response_
   
   ### Uniffle Engine Configurations
   
   _No response_
   
   ### Additional context
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to