EnricoMi commented on code in PR #1434:
URL:
https://github.com/apache/incubator-uniffle/pull/1434#discussion_r1448416592
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServer.java:
##########
@@ -356,7 +354,12 @@ private void waitDecommissionFinish() {
while (isDecommissioning()) {
remainApplicationNum = shuffleTaskManager.getAppIds().size();
if (remainApplicationNum == 0) {
- serverStatus.set(ServerStatus.DECOMMISSIONED);
+ boolean wasDecommissioning =
+ serverStatus.compareAndSet(ServerStatus.DECOMMISSIONING,
ServerStatus.DECOMMISSIONED);
+ if (!wasDecommissioning) {
+ break;
Review Comment:
What about
```suggestion
LOG.info("Ready to decommission but decommissioning state left
unexpectedly.");
break;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
